Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update setup.md - adding playServicesLocationVersion #436

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Bilal-Abdeen
Copy link

The setup instructions suggest adding googlePlayServicesVersion, playServicesVersion or playServicesLocationVersion to the android/build.gradle file.
Only using the last one playServicesLocationVersion works. The other 2 throw dependency errors.

Summary

  1. I updated the version numbers referenced in the setup instructions for the android/build.gradle file.
  2. Adding googlePlayServicesVersion or playServicesVersion throws an error while using playServicesLocationVersion works.

#398

Test Plan

I tried using googlePlayServicesVersion and using playServicesVersion. In both scenarios, building the app (by executing npx react-native run-android) throws an error regarding dependencies. I used playServicesLocationVersion. The app was built successfully, and the current location was picked correctly.

1. I updated the version numbers in the android/build.gradle file. 
2. Adding googlePlayServicesVersion or playServicesVersion throws an error while using playServicesLocationVersion works.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant